Skip to content

Ignore the request checksum when creating a delete marker - #6267

Open
maeldonn wants to merge 2 commits into
development/9.4from
bugfix/CLDSRV-985
Open

Ignore the request checksum when creating a delete marker #6267
maeldonn wants to merge 2 commits into
development/9.4from
bugfix/CLDSRV-985

Conversation

@maeldonn

@maeldonn maeldonn commented Sep 1, 2026 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

A delete marker has no body, but createAndStoreObject took its checksum
from the request headers, which on a multi-object delete cover the request
XML. On an external location the mismatch failed the put, and the rollback
error then hit an unguarded result.versionId in multiObjectDelete, killing
the worker with a 502. Skip the header checksum for delete markers, and
guard the result so any later error is returned as a proper S3 error.

Issue: CLDSRV-984

@maeldonn
maeldonn requested review from a team, DarkIsDude and SylvainSenechal September 1, 2026 15:15
@bert-e

bert-e commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-985 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.3

  • 9.5.0

Please check the Fix Version/s of CLDSRV-985, or the target
branch of this pull request.

@codecov

codecov Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9902 1 9901 0
View the top 1 failed test(s) by shortest run time 
should create an encrypted bucket and upload an object::KMIP backed server-side encryption should create an encrypted bucket and upload an object
Stack Traces | 40s run time 
Timeout of 40000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (.../functional/kmip/serverside_encryption.js)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@bert-e

bert-e commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-985 contains:

  • 9.5.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.3

  • 9.5.0

Please check the Fix Version/s of CLDSRV-985, or the target
branch of this pull request.

leif-scality
leif-scality reviewed Sep 1, 2026
View reviewed changes
Comment thread lib/api/apiUtils/object/createAndStoreObject.js Outdated
Comment thread lib/api/apiUtils/object/createAndStoreObject.js
@bert-e

bert-e commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@maeldonn
Ignore the request checksum when creating a delete marker
06ea87b 
A delete marker has no body, but createAndStoreObject took its checksum
from the request headers, which on a multi-object delete cover the request
XML. On an external location the mismatch failed the put, and the rollback
error then hit an unguarded result.versionId in multiObjectDelete, killing
the worker with a 502. Skip the header checksum for delete markers, and
guard the result so any later error is returned as a proper S3 error.

Issue: CLDSRV-984
@maeldonn
maeldonn marked this pull request as ready for review September 2, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leif-scality leif-scality leif-scality approved these changes
@DarkIsDude DarkIsDude Awaiting requested review from DarkIsDude DarkIsDude was automatically assigned from scality/raving-robots
@SylvainSenechal SylvainSenechal Awaiting requested review from SylvainSenechal SylvainSenechal was automatically assigned from scality/raving-robots

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maeldonn @bert-e @leif-scality